This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Prepare changelog for maps-v1.3.0 (2020.02-release-vanillashake) release #16247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some unnecessary files.
Save step had been removed.
Use the latest Xcode 11.3.1 and run the tests on iPhone 11 with the latest iOS 13.3.
GCC complains about this variable being potentially not initialized.
This reverts commit b5c386a.
* [android] and jni interface for source zoom delta * handle nullopt in setter and getter * Use jni::Integer
and get rid of `SpriteLoaderWorker`, use `scheduleAndReplyValue()` API instead.
This will move geojson-vt-cpp and shelf-pack-cpp to mapbox-base collection of libraries.
Downloaded resources are put in the buffer and inserted in the database in batches. Before this change, the buffer was flushed only at the network response callback and thus it never got flushed if the last required resources were present locally and did not initiate network requests -> it caused freezing. Now the buffer is flushed every time the remaining resources container gets empty.
Thus we do not need to include specific headers to use `{set|get}Property`
API with key constants.
Add a script that for everything we link against mbgl-core, it will check the license and generate a file all the dependencies listed with the respective authors, project urls and license.
They have a different license from the rest of the code and this will make it explicit. Also the script for generating the license will dectect them correctly.
Also make sure it will be always up to date by using the nitpick bot to enforce it.
For historical reasons, developers may come here when looking for the Mapbox Maps SDK. Direct them to the right repository so they don’t get confused thinking Mapbox only provides a C++ library.
* [android] Add jni binding for min and max pitch * Update CHANGELOG.md
This reverts commit f5c4808.
|
Will be better to create new branch for out-of-release cycle release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release maps-v1.3.0
Changes since maps-v1.2.1 release
🐞 Bug fixes
[core] Fix offline region download freezing (#16230)
Downloaded resources are put in the buffer and inserted in the database in batches.
Before this change, the buffer was flushed only at the network response callback and thus it never got flushed if the last required resources were present locally and did not initiate network requests - it caused freezing.
Now the buffer is flushed every time the remaining resources container gets empty.
✨ New features
[core] Add Layer::serialize() method (#16231)
New method allows serialization of a layer into a Value type, including all modifications done via runtime style API. New method is also an enabler for Style object serialization (sources, layers, etc).
[android] Add jni binding for min and max pitch (#16236)
[offline] Offline tool does not hang on 404 error (#16240)
The missing resource gets skipped and teh offline region download continues.
Changes to
mbgl::FileSourceManager::getFileSource()(#16238)It returns now
mbgl::PassRefPtr<FileSource>(previously wasstd::shared_ptr<FileSource>) in order to enforce keeping the strong reference to the returned object.Breaking code example:
auto fs = FileSourceManager::getFileSource(); fs->..Posible fix:
std::shared_ptr<FileSource> fs =;The
mbgl::OnlineFileSourceclass cannot be used directly (#16238)Clients must use the parent
mbgl::FileSourceinterface instead.Breaking code example:
std::shared_ptr<OnlineFileSource> onlineSource = std::static_pointer_cast<OnlineFileSource>(FileSourceManager::get()->getFileSource(..));Possible fix:
std::shared_ptr<FileSource> onlineSource = FileSourceManager::get()->getFileSource(..);Launch Checklist
@mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdkif this PR adds or updates a public API