Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] FileSource API improvements #16238

Merged
merged 7 commits into from
Feb 26, 2020
Merged

[core] FileSource API improvements #16238

merged 7 commits into from
Feb 26, 2020

Conversation

pozdnyakov
Copy link
Contributor

@pozdnyakov pozdnyakov commented Feb 26, 2020 •
edited
Loading

  • FileSourceManager::getFileSource() returns PassRefPtr: enforcing ownership model
  • Move setResourceTransform() to the parent interface, clients never access OnlineFileSource directly

@pozdnyakov pozdnyakov self-assigned this Feb 26, 2020
@pozdnyakov pozdnyakov marked this pull request as ready for review February 26, 2020 15:58
@pozdnyakov pozdnyakov requested a review from 1ec5 as a code owner February 26, 2020 15:58
alexshalamov
alexshalamov approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@alexshalamov alexshalamov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, +update chengelog

@pozdnyakov pozdnyakov force-pushed the mikhail_file_source_api_improvements branch from 67a0433 to d410b47 Compare February 26, 2020 16:06
@pozdnyakov pozdnyakov force-pushed the mikhail_file_source_api_improvements branch from d410b47 to c8caac7 Compare February 26, 2020 16:20
tmpsantos
tmpsantos approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@tmpsantos tmpsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there a way to add a utest for Pass?

@pozdnyakov pozdnyakov force-pushed the mikhail_file_source_api_improvements branch from c8caac7 to ac5eda8 Compare February 26, 2020 19:19
@pozdnyakov
Copy link
Contributor Author

LGTM, but is there a way to add a utest for Pass?

Added the Pass.NoCopy unit test with the latest commit.

@pozdnyakov pozdnyakov merged commit 1374f94 into master Feb 26, 2020
@pozdnyakov pozdnyakov deleted the mikhail_file_source_api_improvements branch February 26, 2020 20:32
@1ec5 1ec5 mentioned this pull request Feb 27, 2020
Merged
@alexshalamov alexshalamov mentioned this pull request Feb 28, 2020
Closed
2 tasks
@1ec5 1ec5 mentioned this pull request Feb 28, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexshalamov alexshalamov alexshalamov approved these changes

@tmpsantos tmpsantos tmpsantos approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees

@pozdnyakov pozdnyakov

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pozdnyakov @tmpsantos @alexshalamov