Static analyzer warning in Sprite::parseJSON()

[kkaefer]

Caught by Xcode 7:

/path/to/mapbox-gl-native/src/mbgl/map/sprite.cpp
/path/to/mapbox-gl-native/src/mbgl/map/sprite.cpp:148:17: Function call argument is an uninitialized value
/path/to/mapbox-gl-native/src/mbgl/map/sprite.cpp:48:13: Calling 'Sprite::parseJSON'
/path/to/mapbox-gl-native/src/mbgl/map/sprite.cpp:120:1: Entered call from 'operator()'
/path/to/mapbox-gl-native/src/mbgl/map/sprite.cpp:130:75: Entering loop body
/path/to/mapbox-gl-native/src/mbgl/map/sprite.cpp:131:13: 'name' initialized to a garbage value
/path/to/mapbox-gl-native/src/mbgl/map/sprite.cpp:148:17: Function call argument is an uninitialized value

/cc @kkaefer

[kkaefer]

@1ec5 can you confirm this fixes the analyzer warning in Xcode 7?

[1ec5]

@kkaefer Yes, these warnings are resolved. The remaining analyzer warnings are covered upstream by memononen/libtess2#19, angusj/polyclipping#134, and tonymillion/Reachability#103.

[mb12]

@1ec5 Just wanted to share that I had an older repo (without these changes). There in I was getting incredibly long time (over a minute) in style destructor. It was showing up when switching styles (in the Android sample app). The issue happened only when I was trying with my style changes (minor changes over emerald-v7). It did not happen on iOS or with any of the bundled styles. The issue went away after I merged this specific change in sprite json parsing. Thanks a lot for fixing this.

[1ec5]

Glad to hear it, @mb12, although @kkaefer gets the credit for this one. I originally wrote up #1749 as an issue, then @kkaefer morphed it into a PR with his fix.