This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add admonition about hub pull-request #6632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hub pull-request is a nifty tool, but it must be used with care. Commandeering an older issue opened by another contributor creates confusion about who fixed the issue and when. It can be especially problematic if the pull request is declined or off-topic, forcing other contributors to redo the original issue report and forcing visitors to follow a trail of derailed issues-turned-PRs.
|
@1ec5, thanks for your PR! By analyzing the history of the files in this pull request, we identified @friedbunny, @incanus and @boundsj to be potential reviewers. |
boundsj
approved these changes
Oct 7, 2016
|
I assume external contributors will not have the permissions necessary to run |
|
Oh, I hadn’t considered that. Closing – Mapboxers, considered yourselves warned. 😛 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hub pull-requestis a nifty tool, but it must be used with care. Commandeering an older issue opened by another contributor creates confusion about who fixed the issue and when. It can be especially problematic if the pull request is declined or fails to fix the original issue. Other contributors are then forced to redo the original issue report, and visitors must follow a trail of derailed issues-turned-PRs./ref #1749 (comment) #3563 (comment)