Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Linux support #27

Merged
merged 5 commits into from
Feb 21, 2014
Merged

Linux support #27

merged 5 commits into from
Feb 21, 2014

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Feb 18, 2014

  • - Get libllmr.a building on Linux - targeting Ubuntu precise with upgraded g++ 4.8 (or 4.7)
  • - Add docs to readme for how to get set up on Ubuntu Precise
  • - Write a wrapper like we have for osx/ios

springmeyer pushed a commit that referenced this pull request Feb 3, 2014
springmeyer pushed a commit that referenced this pull request Feb 3, 2014
This was referenced Feb 3, 2014
Closed
@springmeyer
Copy link
Contributor Author

@kkaefer fyi, linux compile issues with recent commits:

  g++-4.8 '-DNDEBUG' -I../include  -std=c++11 -O3 -I/usr/local/include  -MMD -MF /home/ubuntu/llmr-native/out/Release/.deps//home/ubuntu/llmr-native/out/Release/obj.target/llmr-osx/src/style/sprite.o.d.raw  -c -o /home/ubuntu/llmr-native/out/Release/obj.target/llmr-osx/src/style/sprite.o ../src/style/sprite.cpp
../src/style/sprite.cpp: In member function ‘void llmr::Sprite::loadImage(const string&)’:
../src/style/sprite.cpp:127:46: error: ‘png_const_bytep’ was not declared in this scope
     if (buffer.length < 8 || !png_check_sig((png_const_bytep)buffer.data, 8)) {
                                              ^
../src/style/sprite.cpp:143:88: error: cannot convert ‘uint32_t* {aka unsigned int*}’ to ‘png_uint_32* {aka long unsigned int*}’ for argument ‘3’ to ‘png_uint_32 png_get_IHDR(png_structp, png_infop, png_uint_32*, png_uint_32*, int*, int*, int*, int*, int*)’
         png_get_IHDR(png, info, &width, &height, &depth, &color, &interlace, NULL, NULL);
                                                                                        ^
make[1]: *** [/home/ubuntu/llmr-native/out/Release/obj.target/llmr-osx/src/style/sprite.o] Error 1
make[1]: Leaving directory `/home/ubuntu/llmr-native/out'
make: *** [llmr] Error 2

springmeyer pushed a commit that referenced this pull request Feb 3, 2014
@incanus
Copy link
Contributor

incanus commented Feb 13, 2014

@ansis @yhahn you guys have any spare cycles for taking a crack at this? We don't have anyone banging on the door for a Linux build, but it would help with testing and it would be good to know how we look here.

@incanus
Copy link
Contributor

incanus commented Feb 13, 2014

this = third checkbox = "Write a wrapper like we have for osx/ios"

@ansis
Copy link
Contributor

ansis commented Feb 14, 2014

I can attempt this next week, probably with plenty of help from @kkaefer

@kkaefer
Copy link
Contributor

kkaefer commented Feb 14, 2014

👍

@ansis
Copy link
Contributor

ansis commented Feb 18, 2014

A linux wrapper is implemented in linux-wrapper. This should probably be merged with/replace the osx wrapper, but I don't understand gyp well enough to know how to know how to properly merge the gyp files (with the xcode_settings and all that).

@springmeyer
Copy link
Contributor Author

@ansis - nice work! I'm happy to help with gyp, so I'll take a look at this later today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants