-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Running
|
|
The make iproj failure looks unrelated to this change. If you haven't run that lately, you may need to make clean && make distclean first. |
I believe this is simply the fact that we're loading lots of tiles at high zoom levels along the flight path. #2006 will help, but #1626 is the main reason for the experience being worse than in GL JS. |
Just ran them both and tried again. Same error message. FWIW, the first attempt I ran |
@1ec5 found the problem. Turns out I didn't have |
I didn't include the world tour on iOS because we're out of room to add more gear menu options without scrolling, but it would be trivial to do so. |
Corrected some fairly opaque code that was incorrectly ported from GL JS the first time around in #3171, causing the trajectory to extend far into the Earth’s orbit. Also transition pitch while flying, call transition frame/finish callback functions, and recognize the same “speed” and “curve” parameters that GL JS does. Fixes #3296, fixes #3297.
A new Debug menu command takes you on a tour of the world by air.
dc3af1f
to
4e0e816
Compare
This PR fixes the trajectory of
mbgl::Map::flyTo()
to stay within the Earth’s atmosphere. When this function was originally ported from GL JS, there was apparently some confusion between zoom level and scale.flyTo()
now transitions the pitch in addition to the position and bearing; calls transition frame/finish callback functions, allowing client code to chain animations; and recognizes the samespeed
andcurve
parameters as GL JS. Unfortunately, these two parameters appear to be specific to the animation formulae and not expressed in physical units; I haven’t exposed them publicly because I don’t know of a good way to explain them other than “numbers that you fiddle with”. (They come from mapbox/mapbox-gl-js@983ae5e.)A
-flyToCamera:withDuration:completionHandler:
method has been added to the OS X version of MGLMapView. It works just like the iOS version, which I refactored to accommodate future variations that specify speed, easing, etc. In the osxapp demo application, the Debug menu now has a “World tour” command that takes you on a grand tour of the world by air, demonstratingflyTo
functionality. The same demonstration is available in iosapp via the gear menu.Fixes #3296, fixes #3297.
/cc @adam-mapbox @friedbunny @zugaldia @incanus @bleege