Affix user dot on screen in user tracking mode #3589

1ec5 · 2016-01-17T20:41:41Z

Place the user dot at a fixed location on screen in user tracking mode, eliminating the jumping effect between user location updates. ~~In course tracking mode, weight the user puck down towards the bottom of the view, since it’s more important to see the road ahead than to see whoever’s tailgating you.~~ Added a new property to MGLMapView that controls the position of the user dot or user puck. By default, the user dot/puck is fixed in the center of the view, but it can be shifted to the top or bottom (e.g. for a GPS-style turn-by-turn view).

Conceptually, we now rely on entity interpolation to smooth out the large jumps between location updates. As in MapKit, the user dot may be up to one second behind where Core Location thinks the device is. When user tracking is initially enabled, MGLMapView “flies” to the first location reported by Core Location. This process may take longer than a second, but it gives the user more context as to their current location than the standard easing that MapKit performs.

Affix user dot
Fly to initial user location
Allow the user dot’s callout view to stay open (User dot callout view dismisses when user location changes slightly #2618, Annotation callout closes automatically when changing the viewport #3154)
Weight user puck
Make user dot location configurable

Depends on #3583. Fixes #1041 and fixes #2600. #1582 complements this PR by smoothing the user dot’s motion outside of user tracking mode, using view-based animation.

/cc @friedbunny @zugaldia

1ec5 · 2016-01-18T08:06:33Z

platform/ios/src/MGLMapView.mm

-    else if (self.direction < snapTolerance || self.direction > 360 - snapTolerance)
+    else if ((self.direction < snapTolerance || self.direction > 360 - snapTolerance)
+             && self.userTrackingMode != MGLUserTrackingModeFollowWithHeading
+             && self.userTrackingMode != MGLUserTrackingModeFollowWithCourse)


Note to self to remove this change once #3588 lands.

1ec5 · 2016-01-18T19:36:03Z

Tentatively putting on 3.1.0, since it’s ready. Just needs lots of testing.

1ec5 · 2016-01-19T01:50:09Z

platform/ios/src/MGLMapView.mm

+                MGLMapCamera *camera = self.camera;
+                camera.centerCoordinate = self.userLocation.location.coordinate;
+                camera.heading = course;
+                camera.altitude = newLocation.horizontalAccuracy;


This approach seems to be more reliable, and it also works when the map is tilted, something unsupported by the old code, which was ported from the raster SDK, which didn’t support tilting.

Happy that this is simplified! The camera movement is much slicker, too.

One continued quibble is that highly-accurate location fixes zoom in too far and context is lost. This is somewhat mitigated by the camera animation, but perhaps we could also adopt a minimum altitude?

~~We should additionally consider only zooming in if the map's zoom level is relatively low; i.e., Apple Maps doesn't change the altitude/zoom unless the map is zoomed out to ~z8.~~ Strike that, we already do this at <z10.

I'm also seeing this zoom in beyond the accuracy ring, which is unintuitive.

You're right, it does always seem to zoom into z18 for some reason. Perhaps it's because iOS-specific code assumes a field of view of 30 degrees, which is less than what some mbgl calculations assume.

Fixed in dbfc363. I haven’t nailed down exactly what MapKit does, but it does seem to like z14 quite a lot.

friedbunny · 2016-01-19T12:49:25Z

Quick zoom and two-finger zoom do not appear to take into account the content insets, which means the user dot is moved during these gestures while user tracking is enabled... and then moved back to the proper placement afterwards.

1ec5 · 2016-01-19T15:46:53Z

Ah, good catch. All the gestures need to be updated to account for the content inset.

Additionally, heading changes, which come in much more frequently than location changes, tend to interrupt any running animation to the new location during heading tracking mode. The animation for heading changes needs to also pan to the current location, not just rotate.

1ec5 · 2016-01-19T19:09:55Z

Quick zoom and two-finger zoom do not appear to take into account the content insets

Fixed in d32e0e6ed7d1a27b31b374e34a6fac1ea48551ee. In that change, for MapKit parity, I also removed the logic that kicks you out of user tracking mode if your zoom gesture is centered somewhere other than the user dot.

1ec5 · 2016-01-19T19:34:36Z

Failing builds are due to #1828.

1ec5 · 2016-01-20T07:11:49Z

Additionally, heading changes, which come in much more frequently than location changes, tend to interrupt any running animation to the new location during heading tracking mode.

This is also the current behavior. Fixing it will require #3625 and is out of scope for this PR.

friedbunny · 2016-01-20T18:35:26Z

In user tracking mode, keep the user dot in a fixed location on screen, instead easing the map view so that the fixed location corresponds to the new user location. There is one exception: MGLMapView reacts to the first location update the same way as before, so that it appears to move to where the user dot has been all along. In course tracking mode, weight the user dot down towards the bottom of the view, since it’s more important to see the road ahead than the road behind. Fixes #2600, and #1041 to some extent.

Fly to the user location when entering user tracking mode. Keep user location updates from interfering with the initial flight.

Don’t close the user location annotation’s callout when the user location changes in user tracking mode.

Don’t update the user location annotation’s coordinates until after the transition to the first reported location is complete.

Outside of user tracking mode, the user dot moves in spurts, so view synchronization performance isn’t an issue.

Calling -setUserTrackingMode:animated: with animated set to NO should jump instantaneously to the first reported location.

The user dot or user puck’s position is now configurable via a new alignment property in any user tracking mode. Also, -setUserTrackingMode:animated: is now exposed publicly, and setting its animated parameter to NO skips the initial animation.

Per MapKit behavior, zooming or rotating with a gesture can no longer kick the user out of user tracking mode. In user tracking mode, the zoom animation is always anchored on the user dot, wherever it may be.

When entering user tracking mode from a low zoom level, zoom in to z14 regardless of the location’s horizontal accuracy.

1ec5 · 2016-01-20T19:44:02Z

Everything passes; merging.

1ec5 added feature iOS Mapbox Maps SDK for iOS labels Jan 17, 2016

1ec5 self-assigned this Jan 17, 2016

1ec5 added this to the ios-v3.2.0 milestone Jan 17, 2016

1ec5 added the in progress label Jan 17, 2016

This was referenced Jan 17, 2016

Animate the user dot #1582

Merged

Content insets #3583

Merged

Offset map center #2600

Closed

1ec5 added ✓ ready for review and removed in progress labels Jan 18, 2016

1ec5 mentioned this pull request Jan 18, 2016

User location tracking is rough #1041

Closed

1ec5 reviewed Jan 18, 2016
View reviewed changes

1ec5 modified the milestones: ios-v3.1.0, ios-v3.2.0 Jan 18, 2016

1ec5 force-pushed the 1ec5-dot-jank-1041-2 branch 2 times, most recently from bc445aa to 44800c9 Compare January 19, 2016 01:48

1ec5 reviewed Jan 19, 2016
View reviewed changes

1ec5 mentioned this pull request Jan 19, 2016

Animated user dot should pass through batched updates #3610

Closed

1ec5 force-pushed the 1ec5-dot-jank-1041-2 branch from d32e0e6 to 8ed2249 Compare January 20, 2016 06:32

1ec5 mentioned this pull request Jan 20, 2016

Concurrent transition animations #3625

Open

tobrun mentioned this pull request Jan 20, 2016

Affix user dot on screen in user tracking mode #3626

Closed

1ec5 mentioned this pull request Jan 20, 2016

Smooth animation in user tracking mode #3629

Closed

1ec5 force-pushed the 1ec5-dot-jank-1041-2 branch from dbfc363 to 7986ee5 Compare January 20, 2016 18:56

1ec5 added 13 commits January 20, 2016 11:02

[ios] Fly to user location

41ce7b2

Fly to the user location when entering user tracking mode. Keep user location updates from interfering with the initial flight.

[ios] Leave user location callout open when tracking

51be461

Don’t close the user location annotation’s callout when the user location changes in user tracking mode.

[ios] Eliminated jump after flight to first location

2519255

Don’t update the user location annotation’s coordinates until after the transition to the first reported location is complete.

[ios] Maintain user tracking mode after orientation change

867e015

[ios] Keep callout attached to moving user dot

59f2c53

[ios] Keep user dot callout open after user location change

35895af

Outside of user tracking mode, the user dot moves in spurts, so view synchronization performance isn’t an issue.

[ios] Non-animated user tracking mode changes

a93e7d7

Calling -setUserTrackingMode:animated: with animated set to NO should jump instantaneously to the first reported location.

[ios, osx] Optionally animate content insets change

65f6eb2

[ios] Maintain user tracking, anchor on user dot during zoom, rotate

5a00427

Per MapKit behavior, zooming or rotating with a gesture can no longer kick the user out of user tracking mode. In user tracking mode, the zoom animation is always anchored on the user dot, wherever it may be.

[ios] Reset user tracking, respect content inset in resetPosition

bd46111

[ios] z14 initially in user tracking mode

460b21e

When entering user tracking mode from a low zoom level, zoom in to z14 regardless of the location’s horizontal accuracy.

1ec5 force-pushed the 1ec5-dot-jank-1041-2 branch from 7986ee5 to 460b21e Compare January 20, 2016 19:43

1ec5 merged commit 460b21e into master Jan 20, 2016

1ec5 removed the ready label Jan 20, 2016

1ec5 deleted the 1ec5-dot-jank-1041-2 branch January 20, 2016 19:48

friedbunny mentioned this pull request Jan 21, 2016

User dot callout view dismisses when user location changes slightly #2618

Closed

1ec5 removed the ✓ ready for review label Jan 22, 2016

This was referenced Jan 22, 2016

Disable user tracking in -setVisibleCoordinates: #3670

Merged

Various user tracking mode corrections #3680

Merged

friedbunny mentioned this pull request Jan 25, 2016

Tweak iOS gestures to be more user tracking friendly #1436

Closed

1ec5 mentioned this pull request Apr 21, 2016

User dot stays in center of view even after map is latitude-constrained #4781

Closed

1ec5 mentioned this pull request Jul 12, 2016

Tracking modes for non-user annotations #5645

Closed

1ec5 mentioned this pull request Jul 26, 2016

reduce flyTo time for large distances #5794

Closed

1ec5 mentioned this pull request Jan 27, 2017

Add map padding to MGLMapView #7883

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Affix user dot on screen in user tracking mode #3589

Affix user dot on screen in user tracking mode #3589

1ec5 commented Jan 17, 2016

1ec5 Jan 18, 2016

1ec5 commented Jan 18, 2016

1ec5 Jan 19, 2016

friedbunny Jan 19, 2016

friedbunny Jan 19, 2016

1ec5 Jan 19, 2016

1ec5 Jan 20, 2016

friedbunny commented Jan 19, 2016

1ec5 commented Jan 19, 2016

1ec5 commented Jan 19, 2016

1ec5 commented Jan 19, 2016

1ec5 commented Jan 20, 2016

friedbunny commented Jan 20, 2016

1ec5 commented Jan 20, 2016

Affix user dot on screen in user tracking mode #3589

Affix user dot on screen in user tracking mode #3589

Conversation

1ec5 commented Jan 17, 2016

1ec5 Jan 18, 2016

Choose a reason for hiding this comment

1ec5 commented Jan 18, 2016

1ec5 Jan 19, 2016

Choose a reason for hiding this comment

friedbunny Jan 19, 2016

Choose a reason for hiding this comment

friedbunny Jan 19, 2016

Choose a reason for hiding this comment

1ec5 Jan 19, 2016

Choose a reason for hiding this comment

1ec5 Jan 20, 2016

Choose a reason for hiding this comment

friedbunny commented Jan 19, 2016

1ec5 commented Jan 19, 2016

1ec5 commented Jan 19, 2016

1ec5 commented Jan 19, 2016

1ec5 commented Jan 20, 2016

friedbunny commented Jan 20, 2016

1ec5 commented Jan 20, 2016