This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::experimental::optional
is likely to become a non-experimental part of the standard library in the next revision, and is more complete than ourmapbox/variant
-based implementation. It's supported by gcc 4.9 and clang 3.5; need to check on iOS/OS X.For brevity, I recommend we define
mbgl/util/optional.hpp
:And then use unqualified
optional<T>
wherever needed in thembgl
namespace.