Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional should provide == and != operators #64

Closed
jfirebaugh opened this issue Jan 19, 2016 · 7 comments
Closed

optional should provide == and != operators #64

jfirebaugh opened this issue Jan 19, 2016 · 7 comments
Labels
Milestone

Comments

@jfirebaugh
Copy link
Contributor

No description provided.

@joto
Copy link
Contributor

joto commented Jan 21, 2016

Our optional implementation is very incomplete compared to the upcoming standard, boost::optional or this implementation. Do we want to keep working on our own?

/cc @springmeyer

See also #63.

@jfirebaugh
Copy link
Contributor Author

I switched mapbox-gl-native over to experimental/optional earlier this week. I support deprecating or removing our implementation.

@springmeyer
Copy link
Contributor

I support deprecating or removing our implementation.

Same 👍 . For the next tagged release let's remove it.

joto added a commit that referenced this issue Jan 22, 2016
@joto joto added the wontfix label Jan 22, 2016
@joto joto closed this as completed Jan 22, 2016
@joto joto mentioned this issue Jan 22, 2016
@refi64
Copy link

refi64 commented Jan 22, 2016

:(

@springmeyer
Copy link
Contributor

I switched mapbox-gl-native over to experimental/optional earlier this week. I support deprecating or removing our implementation.

@jfirebaugh I saw you mention that you hit problems with experimental::optional? Do you see value in keeping mapbox::optional around longer or no?

@springmeyer springmeyer added this to the 1.1.0 milestone Feb 10, 2016
@springmeyer springmeyer reopened this Feb 10, 2016
@jfirebaugh
Copy link
Contributor Author

mapbox-gl-native no longer uses mapbox::optional. We work around a couple of experimental::optional bugs on various implementations:

  • bool operator!=() const is sometimes missing (use !(a == b) instead)
  • T* operator->() const is sometimes broken (use operator* instead)

@springmeyer
Copy link
Contributor

Thanks @jfirebaugh - re-closing this issue then: We'll stick with the current deprecation and future removal (at v2.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants