This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove Python dependency from build #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I'm currently working on replacing update: landed with 502d313 |
|
@kkaefer, thanks for your PR! By analyzing this pull request, we identified @1ec5, @jfirebaugh and @tmpsantos to be potential reviewers. |
|
Not removing |
kkaefer
force-pushed
the
6010-remove-python-dependency
branch
from
ae1cc7c to
532d211
Compare
tobrun
added a commit
that referenced
this pull request
Aug 16, 2016
kkaefer
force-pushed
the
6010-remove-python-dependency
branch
from
532d211 to
08f71b7
Compare
tobrun
added a commit
that referenced
this pull request
Aug 17, 2016
* [android] #5859 - generate espresso tests [android] #5859 - cleanup xml files, use all the same resource id for map view [android] #5859 - update scripts [android] #5859 - update Activity to match mapboxMap naming [android] #5859 - make SurfaceViewMediaControlActivity compatible [android] #5859 - make MarkerViewScaleActivity test generation compatible [android] #5859 - make PolygonActivity test generation compatible [android] #5859 - integration within make file [android] #5859 - made CameraPostion generation safe [android] #5859 - generate sanity test [android] #5859 - add generated test cases [android] #5859 - add documentation * [android] #5859 - remove generated files, introduce gen package, added gitignore to package * [android] #5859 - regenerated test code * [android] #5859 - added AWS gradle plugin + bitrise configuration * [android] #5859 - fixes running locally without having the properties configured * [android] #6010 - remove python from android sdk * [android] #5859 - update docs about aws gradle plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have gotten rid of
gyp, we can eliminate the Python dependency altogether. The remaining python files arescripts/build-shaders.pyscripts/build-version.pyscripts/export-xcconfig.pyand maybe
platform/android/tests/script/devicefarm.pyWe can replace them with node.js scripts, given that we require node.js to be present anyway.