-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
incanus
commented
Aug 5, 2016
- iOS docs bug reported via user.
- Update dependencies for CMake since Switch build system to CMake #5359 landed. (look ok @kkaefer?)
@incanus, thanks for your PR! By analyzing this pull request, we identified @1ec5, @tmcw and @friedbunny to be potential reviewers. |
👍 |
@@ -26,6 +26,7 @@ targets. | |||
- Modern C++ compiler that supports `-std=c++14` | |||
- clang++ 3.5 or later _or_ | |||
- g++-5 or later | |||
- CMake (for build only) | |||
- Python 2.x (for build only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need python anymore afaik.
It would also be great to verify that the test instructions still work and are accurate. |
It appears that we specifically require CMake v3.x+, which on Ubuntu 12.04 requires adding a backport ppa (discovered this by digging around in
Attempting to install with CMake 2.8.7 yields the following error:
|
@@ -26,6 +26,7 @@ targets. | |||
- Modern C++ compiler that supports `-std=c++14` | |||
- clang++ 3.5 or later _or_ | |||
- g++-5 or later | |||
- CMake (for build only) | |||
- Python 2.x (for build only) | |||
- [Node.js](https://nodejs.org/) (for build only) | |||
- [`pkg-config`](https://wiki.freedesktop.org/www/Software/pkg-config/) (for build only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that we're no longer using Oops, looks like we're using it indirectly via pkg-config
either?find_package
in CMake now
I was previously using this to ensure we were compiling and linking against a mason-installed version of Mesa, ran into trouble rebasing 04fc3cb onto master
because now it can't find EGL/egl.h
(which it previously found through pkg-config --cflags
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using find_package
in CMake. However, we are using it indirectly because we are invoking mason
(which could call pkg-config
based on the script.sh
) when there is no mason.ini
file yet in the package. As we move on and more of the packages we use contain a mason.ini
in the precompiled tarball download, we can remove the on-demand mason.ini
creation, which removes the pkg-config
requirement for Mapbox GL Native.
For what it's worth, we only require Python for creating the shader files and version headers, but we can easily move this to node.js, which we require anyway because of our use of npm
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created ticket for Python removal: #6010
Yes, we require CMake 3.1 due to features we used that are not present before 3.1. |
I rebased the development branch onto |
CI Tested and Approved. We're documented once again! |