-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Have you tried I tested the Node.js build previously during this pull request and it was building properly at that time. |
@mikemorris this is from a completely fresh clone and install. Followed these steps exactly:
|
Running |
In |
@mikemorris it does, however when requiring and starting a project containing the build, I get the following error:
|
Ugh, this looks like it's not linking |
@bsudekum just tried to reproduce this. The failing I couldn't reproduce the |
@kkaefer yeah, this could be a dev environment issue as I am running OSX Sierra and Xcode 8. I do however have access to xcode 7. |
¯_(ツ)_/¯ |
Um, I'd be kinda surprised if it was able to actually render anything without selecting a pixel format, unless this symbol was simply removed in OSX Sierra or something? |
@bsudekum are you still running into this issue? |
@kkaefer @mikemorris retracting that previous statement. Although I was able to build and start my node project with that commented out, after making a request to the local server, I ran into similar errors. @kkaefer So yes, still running into this error. |
@bsudekum I managed to reproduce this error on macOS Sierra only. Starting to investigate now. |
@bsudekum note that GLFW is currently broken on macOS Sierra |
@bsudekum please note that node-pre-gyp errors are expected and normal. However, as you indicated, the build continues and should now produce a properly linked library. I ran both the node tests, as well as the rendering test suite and got no errors. |
@kkaefer you rock. |
Platform: node
Mapbox SDK version: master
Steps to trigger behavior
git clone mapbox-gl-native...
cd mapbo-gl-native
npm install --build-from-source
Expected behavior
Building
node-mapbox-gl-native
Actual behavior
Errors on gyp:
/cc @mikemorris @springmeyer @kkaefer