This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make MGLMapView non opaque by default #7859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you open a PR to fix an issue, please mention that issue number: #7256 in this case. GitHub also allows you to automatically close an issue simply by including “Fixes #7256” (or similar). GitHub suggests doing this in the commit message, but that leads to a lot of noise if you end up rebasing — better to do it in the PR body. (Note that issues auto-close once those commits have been merged into the master branch only.) /cc @jmkiley |
boundsj
approved these changes
Jan 25, 2017
|
We should add notes to the ios and macos changelogs. |
fabian-guerra
force-pushed
the
fabian-opaque-ness
branch
from
b54f828 to
fd02e7a
Compare
1ec5
suggested changes
Jan 25, 2017
| @@ -5,6 +5,7 @@ | |||
| This version of the Mapbox macOS SDK corresponds to version 3.4.1 of the Mapbox iOS SDK. The two SDKs have very similar feature sets. The main differences are the lack of user location tracking and annotation views. Some APIs have been adapted to macOS conventions, particularly the use of NSPopover for callout views. | |||
|
|
|||
| * Fixed an issue causing MGLMapView’s `camera`’s `heading` to be set to a negative value, indicating an undefined heading, when the map view faces northwest. The heading is now wrapped to between zero and 360 degrees, for consistency with MGLMapView’s `direction` property. ([#7724](https://github.com/mapbox/mapbox-gl-native/pull/7724)) | |||
| * Fixed an issue causing MGLMapView flash of black. ([#7859](https://github.com/mapbox/mapbox-gl-native/pull/7859)) | |||
There was a problem hiding this comment.
This PR doesn’t change anything about the macOS SDK, since MGLMapView has separate implementations on iOS and macOS. The behavior is already correct on macOS, so you can remove this blurb.
1ec5
added
performance
fabian-guerra
force-pushed
the
fabian-opaque-ness
branch
from
d6b566b to
e105cd6
Compare
1ec5
approved these changes
Jan 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #7256 to solve "flash of black" one alternative is set
MGLMapView.opaque = NObut one concern was how this may affect the performance. Changingopaque = NOresulted in a reduction in FPS from an average of 50.63 to 49.61. This is unnoticeable but we can keep tracking this in case something comes up.(Benchmark tests were done using bench app)