This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Replace three maps/mutexes in GlyphAtlas with a single map and mutex #8199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfirebaugh, thanks for your PR! By analyzing this pull request, we identified @tmpsantos, @1ec5 and @artemp to be potential reviewers. |
kkaefer
approved these changes
Feb 28, 2017
| } | ||
|
|
||
| // FIXME: We lock all GlyphSets, but what we should | ||
| // really do is lock only the one we are returning. |
There was a problem hiding this comment.
This Fixme isn't resolved, is it?
There was a problem hiding this comment.
No, but I don't think it'll ever be fixed in the way described here. Instead, we'll do #667.
|
This causes |
After some investigation, the cause seems to be related to the mock file source used in that test returning the reply synchronously. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
GlyphAtlasequivalent of #6835.