This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[node] Don't call callbacks synchronously #8243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes memory.test.js deadlock.
|
@jfirebaugh, thanks for your PR! By analyzing this pull request, we identified @tmpsantos to be potential reviewers. |
|
@jfirebaugh my apologies, I should have told you that I fixed this on this PR: #8249 If you don't mind, we could close this one because on my PR I moved the mock file source to a separated file to be reused in other tests. |
kkaefer
reviewed
Mar 2, 2017
| } else { | ||
| t.fail('unhandled file request: ' + req.url); | ||
| } | ||
| setTimeout(function () { |
There was a problem hiding this comment.
process.nextTick is more efficient than setTimeout(, 0)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes memory.test.js deadlock (#8199 (comment)).