This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Disable program caching on Adreno 3xx, 4xx, and 5xx GPUs due to known bugs #9574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Jul 21, 2017
kkaefer
approved these changes
Jul 21, 2017
src/mbgl/gl/context.cpp
Outdated
| // Blacklist Adreno 3xx, 4xx, and 5xx GPUs due to known bugs: | ||
| // https://bugs.chromium.org/p/chromium/issues/detail?id=510637 | ||
| // https://chromium.googlesource.com/chromium/src/gpu/+/master/config/gpu_driver_bug_list.json#2316 | ||
| std::string renderer = reinterpret_cast<const char*>(glGetString(GL_RENDERER)); |
src/mbgl/gl/context.cpp
Outdated
| if (renderer.find("Adreno (TM) 3") != std::string::npos | ||
| || renderer.find("Adreno (TM) 4") != std::string::npos | ||
| || renderer.find("Adreno (TM) 5") != std::string::npos) | ||
| return false; |
There was a problem hiding this comment.
Can we please add braces around complex if statements?
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for #9473.
@Guardiola31337, can you test this on the Nexus 5 and Moto X?