Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Disable program caching on Adreno 3xx, 4xx, and 5xx GPUs due to known bugs #9574

Merged
merged 1 commit into from
Jul 21, 2017
Merged

[android] Disable program caching on Adreno 3xx, 4xx, and 5xx GPUs due to known bugs #9574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/mbgl/gl/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,21 @@ bool Context::supportsVertexArrays() const {

#if MBGL_HAS_BINARY_PROGRAMS
bool Context::supportsProgramBinaries() const {
return programBinary && programBinary->programBinary && programBinary->getProgramBinary;
if (!programBinary || !programBinary->programBinary || !programBinary->getProgramBinary) {
return false;
}

// Blacklist Adreno 3xx, 4xx, and 5xx GPUs due to known bugs:
// https://bugs.chromium.org/p/chromium/issues/detail?id=510637
// https://chromium.googlesource.com/chromium/src/gpu/+/master/config/gpu_driver_bug_list.json#2316
const std::string renderer = reinterpret_cast<const char*>(glGetString(GL_RENDERER));
if (renderer.find("Adreno (TM) 3") != std::string::npos
|| renderer.find("Adreno (TM) 4") != std::string::npos
|| renderer.find("Adreno (TM) 5") != std::string::npos) {
return false;
}

return true;
}

optional<std::pair<BinaryProgramFormat, std::string>>
Expand Down