Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Circle render type #276

Closed
tmcw opened this issue Apr 17, 2015 · 5 comments
Closed

Circle render type #276

tmcw opened this issue Apr 17, 2015 · 5 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Apr 17, 2015

It looks like this was implemented in the past and then removed. There's a discussion that mentions it but no real connecting-the-dots as far as whether and how this would be implemented.

My vote: circles of customizable radius and color are essential for basic data visualization.
@jfirebaugh
Copy link
Contributor

#68 has the main discussion.

@tmcw
Copy link
Contributor Author

tmcw commented Apr 17, 2015

I disagree with the main discussion and feel strongly that we should implement a circle type.

  • Scaled icon circles are not a replacement for absolutely sized generated circles. What the user wants is "a 5px circle", not "choose an sdf sprite, guess what size it is, scale it by 5/14"
  • Circle type increases similarity to Leaflet, OpenLayers, and virtually every other map framework
  • Having a circle in a sprite to draw circles is an inconvenience: scaled circles are one of the main things that people will add via the JavaScript API, and at that point the choice of sprite is mostly baked-in.

@mourner
Copy link
Member

mourner commented Apr 17, 2015

Well, to reiterate what I said in the #68 discussion, I'm fully in support of a dedicated circle type and agree with Tom.

This was referenced Apr 20, 2015
Merged
Closed
@incanus
Copy link
Contributor

incanus commented Apr 22, 2015

We need a circle primitive for iOS as well, for things like https://www.mapbox.com/mapbox-ios-sdk/examples/drawing-circle/ — note the runtime color, opacity, and stroke settings.

@incanus incanus mentioned this issue May 11, 2015
Closed
scothis added a commit that referenced this issue Jun 2, 2015
@scothis
Circle render type
6f9c7e4 
Bare bones definition of a circle type. Presently, there are no layout
properties and only two render properties:
- circle-radius: radius in px (default 1px)
- circle-color: fill color (default black)

Issue: #276
@tmcw tmcw mentioned this issue Jun 2, 2015
Closed
@kkaefer kkaefer mentioned this issue Jun 16, 2015
Closed
scothis added a commit that referenced this issue Jun 17, 2015
@scothis @jfirebaugh
Circle render type
a0dffb6 
Bare bones definition of a circle type. Presently, there are no layout
properties and only two render properties:
- circle-radius: radius in px (default 1px)
- circle-color: fill color (default black)

Issue: #276
@jfirebaugh
Copy link
Contributor

Included in v8.

@brunoabinader brunoabinader mentioned this issue Jul 8, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@incanus @mourner @tmcw @jfirebaugh