Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Port circle render type (v8 styles) #1740

Closed
kkaefer opened this issue Jun 16, 2015 · 1 comment
Closed

Port circle render type (v8 styles) #1740

kkaefer opened this issue Jun 16, 2015 · 1 comment
Labels
GL JS parity For feature parity with Mapbox GL JS

Comments

@kkaefer
Copy link
Contributor

kkaefer commented Jun 16, 2015

We need to port the point symbol type to C++. This type will be able to render plain circles with arbitrary color, which is very useful for visualizing many small features that don't require a particular icon.

There is a JS implementation already which contains the shaders and a general outline of what the feature will look like. Porting it includes:

  • Parse the stylesheet into the correct structures (see style spec for how the JSON looks like)
  • When parsing vector tiles into buckets, generate the OpenGL buffers required for rendering
  • When rendering, add code that renders the buffers with the correct shaders
  • Add tests for correct bucket creation (may not exist in JS yet)
  • Add visual rendering tests (may not exist yet in the test suite)
@kkaefer kkaefer added the GL JS parity For feature parity with Mapbox GL JS label Jun 16, 2015
brunoabinader added a commit that referenced this issue Jun 18, 2015
brunoabinader added a commit that referenced this issue Jun 18, 2015
brunoabinader added a commit that referenced this issue Jun 18, 2015
brunoabinader added a commit that referenced this issue Jun 18, 2015
brunoabinader added a commit that referenced this issue Jun 18, 2015
brunoabinader added a commit that referenced this issue Jun 18, 2015
brunoabinader added a commit that referenced this issue Jun 18, 2015
@jfirebaugh
Copy link
Contributor

#1766

brunoabinader added a commit to mapbox/mapbox-gl-test-suite that referenced this issue Jul 8, 2015
brunoabinader added a commit to mapbox/mapbox-gl-js that referenced this issue Jul 8, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

4 participants