-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3 compatibility #2
Conversation
wow. that is really cool! I was planning to add python3 support myself but did not find the time yet. |
Not yet, but if/when this is accepted, I will try to switch my tinject tool from inquirer to wha+t, should not be hard. |
@lelit a fine piece of work. thank you so much! |
You're welcome! Unfortunately, it seems that I didn't spot all the places:
snippet too. |
I may submit another PR for this if you prefer, but I think the best would be to create a test covering |
you are absolutely right, the test coverage is not where I want it to be. If you like to contribute the test please go ahead. |
This set of commits do tiny cleanups and then make the library usable under Python 3, at least as far as automatic tests can tell.