-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prompt_toolkit 2.0 - Will be released soon. #446
Conversation
57e0919
to
50e5e2b
Compare
5e291ba
to
f033e47
Compare
Hi Jonathan, just I few things I noticed when playing with 2.0 on Windows (in cmd.exe):
Hope this is useful, somehow. Keep up the good work. |
Thanks for pointing out! |
I tried out the new radio_dialog example on Windows 10 and I noticed it ran very slowly. Not sure what's going on, but cProfile shows a ridiculous amount of calls. (All I did was, launch the script and exit it by pushing [tab] and [enter])
|
Hi @biermeester, the start-up time should be much faster now. There were some issues with the calculation of the style. Could you try again? If it's still slow, for Windows 10, I still have to implement the vt100 rendering backend. The Windows console supports now vt sequences, but this needs to be enabled. |
Works fine now! |
Hi @jonathanslenders. I'm totally new to the library and was looking into using this branch, since it is the future. One very basic question that was not obvious from the docs and code: how does one modify container contents? Say I have an HSplit with 4 widgets and I want to insert another one in the middle programmatically, is there a standard way? Nothing short of rebuilding the tree or mucking with internal structures was really apparent from a quick look at the code. Thanks, Jim |
28cd9c8
to
e325fdf
Compare
TODO list:
|
3f8f9d1
to
b521870
Compare
8346a99
to
065c3c6
Compare
If I might make a suggestion here, I often find it quite confusing, particularly when writing key binding code, about the distinction between buffers and documents. I always have to search to find out which attributes are on which, and it's even more confusing that some are on both (but, apparently, you should never mutate a document; I only found this out from reading the code). I don't know if it makes sense to merge them. I think I am starting to understand the difference between the two (although not enough to reliably guess if a given attribute will be on one or the other). A document is a container of text, and a buffer is a document + a cursor position + things like selection and completion popups (is that right?). Perhaps it makes sense to go all the way and make all attributes of I also want to add that I think buffer needs way more "edit level" commands, that make it easier to manipulate the text. Maybe these are already there and I just don't know about them. When implementing things like a "comment/uncomment block" key binding, or even just one space, I have to be very careful to tear apart the text, rearrange it, and put it back. What's annoying is the bookkeeping to keep the cursor in a reasonable position. But even if I am sloppy with it, I at least have to do |
Hi @asmeurer, However, your comment regarding the assertion error when setting text, forcing you to do this: |
What about copying more attributes from document to buffer, so that the end user never has to deal with the document (unless he needs to go low level). For example, it would be awesome if you could mutate |
hi, I am following this PR with great interest since its beginning. At the moment it looks quite good. Is this going to be released soon? |
b1598d7
to
fb114bb
Compare
(Clicking on a DummyControl made the application crash.)
Hi everyone! Check out the changelog: https://github.com/jonathanslenders/python-prompt-toolkit/blob/2.0/CHANGELOG It would be nice if at some point, we can have all prompt_toolkit applications running on 2.0. ;) Cheers, |
No description provided.