Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Exclude dependencies during build #333

Closed
wants to merge 6 commits into from

Conversation

manuquentin
Copy link
Contributor

  • Adding a build task to generate a ng-admin-only.min.js file without dependencies
  • Mocks requires depencies
  • Add documentation

Refs #322

155K ng-admin-only.min.js
600K ng-admin.min.js

"angular": "~1.3.1",
"angular": "~1.3.1"
},
"devDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to decide which is the default, between ng-admin only and full:

  1. if ng-admin only, all dependencies below must be dependencies, because they are required to work with. Developers will need to include them (it can be done automatically in dev with wiredep, that's what Yeoman does)
  2. if full, all dependencies below must be devDependencies

I think 2 must be for testing purposes only, the target should be 1, and letting the developers do their own build phase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the full the default one, I've named it ng-admin-only.min.js to not break compatibility.

@eranimo
Copy link

eranimo commented Apr 13, 2015

This would be really nice

@manuquentin manuquentin force-pushed the exlude_dependencies_minification branch 5 times, most recently from e699342 to f028b79 Compare April 16, 2015 11:38
@manuquentin manuquentin changed the title [WIP] Exclude dependencies during build [RFR] Exclude dependencies during build Apr 16, 2015
@manuquentin manuquentin force-pushed the exlude_dependencies_minification branch from f028b79 to 18126ab Compare May 11, 2015 10:21
@jpetitcolas
Copy link
Contributor

Needs rebase

@manuquentin manuquentin force-pushed the exlude_dependencies_minification branch from 18126ab to d85f3a5 Compare May 11, 2015 13:01
@fzaninotto
Copy link
Member

Needs rebase... again. @jpetitcolas is this PR still necessary now that we aim for webpack?

@fzaninotto
Copy link
Member

Superseded by #428

@fzaninotto fzaninotto closed this May 15, 2015
@Kmaschta Kmaschta deleted the exlude_dependencies_minification branch March 9, 2017 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants