[RFR] Migrate from require to Webpack #428
Conversation
jpetitcolas
commented
May 11, 2015
jpetitcolas
commented
- Use Webpack to compile JS on the fly
- Add missing code mirror dependencies (for JSON field formatting)
- Use Webpack to compile SASS on the fly
- Update build process to use Webpack
- Remove requirejs dependency
|
Results are pretty encouraging. Using |
| @@ -5,8 +5,7 @@ | |||
| <title>Angular admin</title> | |||
| <meta name="viewport" content="width=device-width"> | |||
| <link rel="stylesheet" href="build/ng-admin.css"> | |||
| <script src="build/angular.js" type="text/javascript"></script> | |||
| <script src="build/ng-admin.js" type="text/javascript"></script> | |||
| <script src="http://localhost:8080/build/ng-admin.min.js" type="text/javascript"></script> | |||
|
We'll have many conflicts with @jeromemacias and @manuquentin PRs. Can you discuss the merging strategy together? |
|
So I closed #333 in favor of this one. It means that you should add the double build (with and without dependencies) to the to-do list of this PR. |
|
Can you rebase please (because of |
|
PR rebased for Two editions are now built: a normal version and a standalone one. The normal one is a light one, including only ng-admin code. The standalone version embeds all dependencies: fonts (as data URL), JS and CSS dependencies, etc. You just have to embed it and a configuration file to get a fully functional version. Protractor tests are red. I'm working on it, and then it would be in RFR. |
|
Need last rebase, sorry. |
| */ | ||
| ma-choice-field select option:empty { | ||
| display:none; | ||
| } |
There was a problem hiding this comment.
Not needed anymore (see #435)
|
Switching to RFR. Don't forget to add |
| @@ -80,8 +80,9 @@ | |||
| "teaser": "Consequuntur id aut soluta aspernatur sit. Aut doloremque recusandae sit saepe ut quas earum. Quae pariatur iure et ducimus non. Cupiditate dolorem itaque in sit.", | |||
| "body": "<p>Aut molestiae quae explicabo voluptas. Assumenda ea ipsam quia. Rerum rerum magnam sunt doloremque dolorem nulla. Eveniet ut aliquam est dignissimos nisi molestias dicta. Dolorum et id esse illum. Ea omnis nesciunt tempore et aut. Ut ullam totam doloribus recusandae est natus voluptatum officiis. Ea quam eos velit ipsam non accusamus praesentium.</p><p>Animi et minima alias sint. Reiciendis qui ipsam autem fugit consequuntur veniam. Vel cupiditate voluptas enim dolore cum ad. Ut iusto eius et.</p><p>Quis praesentium aut aut aut voluptas et. Quam laudantium at laudantium amet. Earum quidem eos earum quaerat nihil libero quia sed.</p><p>Autem voluptatem nostrum ullam numquam quis. Et aut unde nesciunt officiis nam eos ut distinctio. Animi est explicabo voluptas officia quos necessitatibus. Omnis debitis unde et qui rerum. Nisi repudiandae autem mollitia dolorum veritatis aut. Rem temporibus labore repellendus enim consequuntur dicta autem. Illum illo inventore possimus officiis quidem.</p><p>Ullam accusantium eaque perspiciatis. Quidem dolor minus aut quidem. Praesentium earum beatae eos eligendi nostrum. Dolor nam quo aut.</p><p>Accusamus aut tempora omnis magni sit quos eos aut. Vitae ut inventore facere neque rerum. Qui esse rem cupiditate sit.</p><p>Est minus odio sint reprehenderit. Consectetur dolores eligendi et quaerat sint vel magni. Voluptatum hic cum placeat ad ea reiciendis laborum et. Eos ab id suscipit.</p><p>Enim corporis tenetur quia molestias qui tempore ullam. Explicabo sunt quis alias autem tempora modi aliquid. Modi in enim neque enim. Natus quia dolor eum. Deserunt porro ex doloribus quis architecto impedit soluta. Accusamus sunt animi quidem expedita ullam reiciendis vitae. Autem voluptates neque rerum amet. Vero non ipsa veritatis aspernatur placeat. Pariatur sequi voluptas eos qui pariatur dignissimos aut et. Ut odit et ipsa provident eum. Omnis autem eveniet expedita maiores repellendus quia. Et voluptas quo eum exercitationem impedit vitae.</p>", | |||
| "views": 559, | |||
| "published_at": "2012-08-24", | |||
| "tags": [] | |||
| "published_at": "2012-08-22", | |||
There was a problem hiding this comment.
Should revert this file, and perhaps try to ignore further modifications on it using .gitignore?
jpetitcolas
changed the title
|
Need another reabse (and it will re-trigger Travis). |
Fix Angular template compilation Add missing Code Mirror extensions Fix CSS generation Fix last icon paths issues
|
Karma unit seems to freeze, but no locally. Asking a debug VM to Travis. |
|
Green! \o/ |
[RFR] Migrate from require to Webpack
|
|
|
|
