Fix unnecessary update of ra-input-rich-text on edit #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It seems the tests are failing though |
roychoo
force-pushed
the
fix-ra-input-rich-text
branch
from
ee086ae
to
b38e3ca
Compare
roychoo
force-pushed
the
fix-ra-input-rich-text
branch
from
b38e3ca
to
661b8a1
Compare
|
Hi just want to check, did anyone take the opportunity to review the code? |
djhi
approved these changes
Apr 13, 2019
fzaninotto
requested changes
Apr 16, 2019
| }); | ||
|
|
||
| it('should call text-change event only once when editing', async () => { | ||
| const mockFn = jest.fn(); |
There was a problem hiding this comment.
Are you sure ? I still see mockFn
There was a problem hiding this comment.
Oh sorry I misunderstood, I thought you meant the test description. Will make the required change in another 3 hours.
added 4 commits
April 16, 2019 16:03
quill require mock on some DOM apis while in test.
1. add reason for shim 2. add reason for using jest fake timers
djhi
requested changes
Apr 19, 2019
| }); | ||
|
|
||
| it('should call text-change event only once when editing', async () => { | ||
| const mockFn = jest.fn(); |
There was a problem hiding this comment.
Are you sure ? I still see mockFn
fzaninotto
approved these changes
Apr 19, 2019
djhi
approved these changes
Apr 19, 2019
|
Thanks! |
|
Thanks for the review and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in ra-input-rich-text,
whenever the text changes, below is the sequence of events happening.
Original text
<p>test</p><p>test1</p>onTextChangefiredcomponentDidUpdatefired<p>test</p>, but unecessaryonTextChangefired again.2nd issue is that, it seems quilljs is always adding additional
<p>after this methodONLY for the text that has special characters, i.e
ARTÍCULO 1.- El presente reglamento es de observancia obligatoriaafter you boldARTÍCULO 1fixes #3073