Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary update of ra-input-rich-text on edit #3099

Merged
merged 7 commits into from
Apr 19, 2019
Merged

Fix unnecessary update of ra-input-rich-text on edit #3099

merged 7 commits into from
Apr 19, 2019

Commits on Apr 11, 2019

  1. Fix unnecessary update of ra-input-rich-text on edit

    Roy Choo committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    661b8a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. add comments for clarity 

    quill require mock on some DOM apis while in test.
    Roy Choo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    4e81a71 View commit details
    Browse the repository at this point in the history

  2. change description of test

    Roy Choo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    733fa03 View commit details
    Browse the repository at this point in the history

  3. fix test to not use quill internal api

    Roy Choo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    ff4f021 View commit details
    Browse the repository at this point in the history

  4. add more comments for shim and test 

    1. add reason for shim
2. add reason for using jest fake timers
    Roy Choo committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    622d4a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. fix mock function to a more meaningful name

    Roy Choo committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    d0f5f83 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary comments

    Roy Choo committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    9bbfbab View commit details
    Browse the repository at this point in the history