Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Delegate the redirection after logout to authProvider #3269

Merged
merged 8 commits into from
Jul 22, 2019
Merged

[RFR] Delegate the redirection after logout to authProvider #3269

merged 8 commits into from
Jul 22, 2019

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented May 23, 2019 •
edited
Loading

Fixes #2957

  • Implementation
  • Refactor
  • Tests
  • Update documentation

@djhi djhi added this to the 3.0.0 milestone May 23, 2019
@djhi djhi changed the base branch from master to next May 23, 2019 06:56
@djhi djhi changed the title Auth provider logout Delegate the redirection after logout to authProvider May 23, 2019
@djhi djhi force-pushed the auth-provider-logout branch from ec8c6e8 to ad1f104 Compare June 5, 2019 13:23
@djhi djhi mentioned this pull request Jun 22, 2019
Closed
@djhi djhi force-pushed the auth-provider-logout branch from ad1f104 to 6174be0 Compare July 22, 2019 07:42
@djhi djhi changed the title Delegate the redirection after logout to authProvider [RFR] Delegate the redirection after logout to authProvider Jul 22, 2019
fzaninotto
fzaninotto approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, you've even managed to make it backward compatible!

@fzaninotto fzaninotto merged commit 35e5e50 into next Jul 22, 2019
@fzaninotto fzaninotto deleted the auth-provider-logout branch July 22, 2019 21:09
This was referenced Jul 22, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kmaschta Kmaschta Kmaschta left review comments

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djhi @fzaninotto @Kmaschta