Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout problem #1870 #3354

Closed
wants to merge 1 commit into from
Closed

Logout problem #1870 #3354

wants to merge 1 commit into from

Conversation

sarathak
Copy link

fix to Logout problem #1870

@Kmaschta
Copy link
Contributor

Thanks for the PR! There is 2 E2E tests that are failing about the auth redirection.

@Kmaschta Kmaschta added this to the 2.9.4 milestone Jun 22, 2019
@djhi
Copy link
Collaborator

djhi commented Jun 22, 2019

That won't work, I'm facing the same issue in #3269. I don't have a solution yet.
Doing this in this order trigger a state update loop. I'm afraid it will require much more work

@fzaninotto fzaninotto removed this from the 2.9.4 milestone Jun 26, 2019
@djhi
Copy link
Collaborator

djhi commented Jul 25, 2019

#3269 has been merged

@djhi djhi closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarathak @Kmaschta @djhi @fzaninotto @sitenano