Add ability to refetch a query in useQuery and useQueryWithStore #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Apr 6, 2021
fzaninotto
requested changes
Apr 6, 2021
| loading: boolean; | ||
| loaded: boolean; | ||
| } => { | ||
| ): StateResult => { |
There was a problem hiding this comment.
rename to UseQueryWithStoreValue
There was a problem hiding this comment.
It would be a breaking change, right?
There was a problem hiding this comment.
Why? The type wasn't named or exported before this PR.
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
fzaninotto
requested changes
Apr 12, 2021
| UseQueryValue, | ||
| UseGetOneHookValue, | ||
| }; | ||
| export * from './useQueryWithStore'; |
There was a problem hiding this comment.
This won't work: the Query type will conflict with the Query component.
The Query type name is too generic; Something like DataProviderQuery would be better, WDYT?
fzaninotto
requested changes
Apr 12, 2021
| resource?: string; | ||
| payload: object; | ||
| } | ||
|
|
||
| export interface QueryOptions { |
There was a problem hiding this comment.
This one should be named UseQueryOptions. Sorry to find the problems one by one, but the fact that you decided to expose all exports in this file created new problems
8 tasks
fzaninotto
approved these changes
Apr 13, 2021
fzaninotto
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.