Fix field label translation concatenates previous prefix #9648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Feb 6, 2024
slax57
requested changes
Feb 7, 2024
erwanMarmelab
approved these changes
Feb 7, 2024
slax57
approved these changes
Feb 7, 2024
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
<LabelPrefixContextProvider>concatenates previous prefix if it is inside aLabelPrefixContext.It's lead to return translation key such as
resources.posts.fields.title.resources.comments.fields.bodybut it make more sense to simply returnresources.comments.fields.bodyevenLabelPrefixContextis nested inside another.<LabelPrefixContextProvider>was introduce used in this #7710 but keeping previous prefix seems to be useful.Solution
Do not keep previous prefix