Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix field label translation concatenates previous prefix #9648

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Fix field label translation concatenates previous prefix #9648

merged 7 commits into from
Feb 7, 2024

Commits on Feb 6, 2024

  1. Fix: no old LabelPrefix concatenation

    @adguernier
    adguernier committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    73be01f View commit details
    Browse the repository at this point in the history

  2. add tests for LabelPrefixContextProvider

    @adguernier
    adguernier committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9f2dce3 View commit details
    Browse the repository at this point in the history

  3. add a test SimpleFormIterator should have the correct translation keys

    @adguernier
    adguernier committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    587b2c8 View commit details
    Browse the repository at this point in the history

  4. useLabelPrefix hook instead of react context

    @adguernier
    adguernier committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2f56968 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Revert "Fix: no old LabelPrefix concatenation" 

    This reverts commit 73be01f.
    @adguernier
    adguernier committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    27a6483 View commit details
    Browse the repository at this point in the history

  2. do not concatenate previous prefix in <Form>

    @adguernier
    adguernier committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    281586d View commit details
    Browse the repository at this point in the history

  3. set concatenate prop of LabelPrefixContextProvider to false in missin… 

    …g file
    @adguernier
    adguernier committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2cfa418 View commit details
    Browse the repository at this point in the history