Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin black importlib metadata dependencies #248

Conversation

woutervanoorschot
Copy link
Contributor

There is no 0.x next release branch and as such I have created this PR to dev (in conflict with the contributing guidelines)

It fixes errors in the pre commit linting caused by an exception in black 22.1.0 and a deprecation from importlib-metadata >= 5.

Hopefully this is useful and can be merged.

Upgrade to black 22.3.0 to fix `ImportError: cannot import name '_unicodefun' from 'click'`

Pin dependency on importlib-metadata to 4.12.0 to resolve `AttributeError: 'EntryPoints' object has no attribute 'get'`
…m:woutervanoorschot/flask-marshmallow into pin-black-importlib-metadata-dependencies
@woutervanoorschot
Copy link
Contributor Author

I believe the errors are caused by deprecations in werkzeug #1963:

Merge all request and response wrapper mixin code into single Request and Response classes. Using the mixin classes is no longer necessary and will show a deprecation warning. Checking isinstance or issubclass against BaseRequest and BaseResponse will show a deprecation warning and check against Request or Response instead.

The code in https://github.com/marshmallow-code/flask-marshmallow/blob/dev/tests/test_sqla.py should be updated from checking BaseResponse to Response.

Also python 3.6 will be deprecated by these fixes, but python 3.6 is EOL anyway. It should be a new major version

Bump pyupgrade version to python 3.7
Remove azure python 3.6 pipeline
Require python >= 3.7 in setup
Add python 3.10 to tox
@woutervanoorschot
Copy link
Contributor Author

The changes have become a bit bigger in scope to fix all the errors in the pipelines and pre-commit checks. Hopefully it is still readable for a reviewer.

My project depends on the flask-marshmallow package and hopefully this can help keep the development going.

@sirosen sirosen merged commit 3a88e24 into marshmallow-code:dev Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants