Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inline scripts #588

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Refactor inline scripts #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01e4a1f
Refactor inline scripts
martincostello Sep 8, 2023
ecdd4a5
Consume workflow locally
martincostello Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-dotnet-sdk-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ permissions:

jobs:
update-sdk:
uses: martincostello/update-dotnet-sdk/.github/workflows/update-dotnet-sdk.yml@main
uses: ./.github/workflows/update-dotnet-sdk.yml
permissions:
contents: write
pull-requests: write
Expand Down
32 changes: 19 additions & 13 deletions .github/workflows/update-dotnet-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,24 +162,27 @@ jobs:
- name: Validate secrets
id: validate-secrets
uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
env:
APPLICATION_ID: ${{ secrets.application-id }}
APPLICATION_PRIVATE_KEY: ${{ secrets.application-private-key }}
REPO_TOKEN: ${{ secrets.repo-token }}
with:
result-encoding: string
script: |
if (`${{ secrets.repo-token }}`.length !== 0) {
core.setOutput('use-github-app', 'false');
}
else {
if (`${{ secrets.application-id }}`.length === 0 ||
`${{ secrets.application-private-key }}`.length === 0) {
const token = process.env.REPO_TOKEN || '';
let useGitHubApp = 'false';
if (!token) {
if (!process.env.APPLICATION_ID || !process.env.APPLICATION_PRIVATE_KEY) {
core.setFailed('Either the repo-token or both the application-id and application-private-key secrets must be set.');
} else {
core.setOutput('use-github-app', 'true');
}
useGitHubApp = 'true';
}
return useGitHubApp;

# If credentials for a GitHub application were provided, use them to generate a GitHub access token
- name: Generate GitHub application token
id: generate-application-token
if: steps.validate-secrets.outputs.use-github-app == 'true'
if: steps.validate-secrets.outputs.result == 'true'
uses: peter-murray/workflow-application-token-action@8e1ba3bf1619726336414f1014e37f17fbadf1db # v2.1.0
with:
application_id: ${{ secrets.application-id }}
Expand All @@ -189,13 +192,16 @@ jobs:

- name: Assign GitHub token
id: assign-token
env:
APPLICATION_TOKEN: ${{ steps.generate-application-token.outputs.token }}
REPO_TOKEN: ${{ secrets.repo-token }}
shell: pwsh
run: |
if (-Not [string]::IsNullOrEmpty("${{ secrets.repo-token }}")) {
"access-token=${{ secrets.repo-token }}" >> $env:GITHUB_OUTPUT
} else {
"access-token=${{ steps.generate-application-token.outputs.token }}" >> $env:GITHUB_OUTPUT
$accessToken = $env:REPO_TOKEN
if ([string]::IsNullOrEmpty($accessToken)) {
$accessToken = $env:APPLICATION_TOKEN
}
"access-token=${accessToken}" >> $env:GITHUB_OUTPUT

# Checkout the repository so the global.json file can be inspected and
# updated if a new patch version of the SDK is available. The token is
Expand Down