Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release overhaul #67

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Release overhaul #67

merged 1 commit into from
Dec 23, 2024

Conversation

rgoldberg
Copy link
Contributor

@rgoldberg rgoldberg commented Dec 22, 2024

Properly generate bottles.

Use zsh.

Standardize formatting.

See corresponding mas PR at mas-cli/mas#640.

Resolve #66
Resolve #23

@rgoldberg rgoldberg added the enhancement New feature or request label Dec 22, 2024
@rgoldberg rgoldberg requested a review from phatblat December 22, 2024 16:06
@rgoldberg rgoldberg self-assigned this Dec 22, 2024
@rgoldberg rgoldberg force-pushed the 66-release-overhaul branch 2 times, most recently from a9b06a3 to ce03e6c Compare December 22, 2024 17:39
@rgoldberg rgoldberg force-pushed the 66-release-overhaul branch 5 times, most recently from 66425ca to da5116c Compare December 22, 2024 20:00
Use zsh.

Standardize formatting.

Resolve mas-cli#66

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine. I just have a question about the new "Download 1.8.6 bottle" step, which seems like a leftover test.

@rgoldberg
Copy link
Contributor Author

I replied to your question inline there. If it hasn't gone through, please let me know.

@rgoldberg rgoldberg merged commit 02f0d88 into mas-cli:main Dec 23, 2024
2 checks passed
@rgoldberg rgoldberg deleted the 66-release-overhaul branch December 23, 2024 03:03
This was referenced Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release overhaul 🍺 Bottling should produce architecture-specific binaries
2 participants