Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handle more easily selectable on profile page #21479

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Make handle more easily selectable on profile page #21479

merged 6 commits into from
Dec 13, 2022

Conversation

cadars
Copy link
Contributor

@cadars cadars commented Nov 23, 2022

No description provided.

Copy link
Contributor Author

@cadars cadars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it easier to copy handles from other instances (especially on touch screens).

@ineffyble ineffyble added the ui Front-end, design label Nov 24, 2022
@ClearlyClaire
Copy link
Contributor

There is a small issue when the account is locked, in which there will be an additional space and an icon at the end. Could you perhaps add another span wrapping the handle and have the user-select: all on it?

Otherwise this is a very good improvement!

@cadars
Copy link
Contributor Author

cadars commented Nov 25, 2022

Cool, I've wrapped the handle in a span and corrected the CSS as well. Let me know if that works for you!

@evanphilip
Copy link
Contributor

This possibly resolves #21074 and #19850

@evanphilip
Copy link
Contributor

@cadars Thank you so much for this extremely useful pull request!

I think merge is blocked by the whitespace in this blank line, right? I hope this gets merged soon (though I have already patched my instance).

@cadars
Copy link
Contributor Author

cadars commented Dec 13, 2022

@evanphilip Oops. Should be fixed now!

@Gargron Gargron merged commit 52a50c5 into mastodon:main Dec 13, 2022
@cadars cadars deleted the patch-1 branch December 13, 2022 22:16
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Jan 12, 2023
* Make handle more easily selectable on profile page

* Wrap handle in a span

* Add `user-select: all` to span

* remove whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants