Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for go modules #44

Merged
merged 5 commits into from
Oct 27, 2018
Merged

add support for go modules #44

merged 5 commits into from
Oct 27, 2018

Conversation

Atrox
Copy link
Contributor

@Atrox Atrox commented Oct 12, 2018

Hey,

I switched to go modules on my projects and because blackfriday is now supporting go modules too, I'm unable to use hermes because you are importing it with gopkg.in but blackfriday's module path is github.com.

To get the tests working, I switched from gometalinter to golangci-lint. gometalinter does not support go modules yet and it seems other popular projects are switching to golangci-lint too.

My current changes will only work for go 1.11+ projects, if you want we can check in the vendor directory generated by go mod vendor to support the versions below.

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files           3        3           
  Lines         907      907           
=======================================
  Hits          893      893           
  Misses          8        8           
  Partials        6        6
Impacted Files Coverage Δ
hermes.go 77.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1a08c...9d5eaf3. Read the comment docs.

Copy link
Owner

@matcornic matcornic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I will have to test everything next week.
Can you apply requested changed ?

Have a nice day :)

.travis.yml Outdated Show resolved Hide resolved
hermes.go Show resolved Hide resolved
@maxekman
Copy link

Would love to see this merged, it's giving me a lot of trouble in its current state.

Repository owner deleted a comment from Atrox Oct 15, 2018
@Scapal
Copy link

Scapal commented Oct 24, 2018

Is there something blocking this merge?

For the moment I'm forced to do this in my go.mod:
replace github.com/matcornic/hermes v1.2.0 => github.com/Atrox/hermes v1.2.1-0.20181012135037-9d5eaf364c1b

@matcornic matcornic merged commit 9d5eaf3 into matcornic:master Oct 27, 2018
@matcornic
Copy link
Owner

@Atrox @Scapal @maxekman Done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants