Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /v2 suffix for new go modules v2 #45

Merged
merged 3 commits into from
Oct 29, 2018

Conversation

Atrox
Copy link
Contributor

@Atrox Atrox commented Oct 29, 2018

Hey @matcornic

thanks for merging my changes (#44) related to supporting go modules. Because you created a new major version (v2) for the go module changes, we should reflect that in go.mod.

In go modules, if the major version changes, the import path also changes. So I also updated all the examples and the go get in the README.

Thanks,
Atrox

@codecov-io
Copy link

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files           3        3           
  Lines         907      907           
=======================================
  Hits          893      893           
  Misses          8        8           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f305906...f79c2e7. Read the comment docs.

@matcornic matcornic merged commit 5d751c9 into matcornic:master Oct 29, 2018
@Atrox
Copy link
Contributor Author

Atrox commented Oct 29, 2018

Thanks for the quick merge @matcornic! Could you release a new version v2.0.1?

@matcornic
Copy link
Owner

Thanks for the quick merge @matcornic! Could you release a new version v2.0.1?

Done :)

@Atrox
Copy link
Contributor Author

Atrox commented Oct 29, 2018

Awesome, thank you very much. Now everything runs smoothly for me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants