feat(list): update to MDC Web 1.0.0 #740

moog16 · 2019-03-13T19:42:18Z

related #697

codecov-io · 2019-03-13T19:45:16Z

Codecov Report

Merging #740 into rc0.11.0 will increase coverage by 0.4%.
The diff coverage is 91.74%.

@@            Coverage Diff            @@
##           rc0.11.0   #740     +/-   ##
=========================================
+ Coverage      94.6%    95%   +0.4%     
=========================================
  Files            73     73             
  Lines          2928   2984     +56     
  Branches        448    466     +18     
=========================================
+ Hits           2770   2835     +65     
+ Misses           56     48      -8     
+ Partials        102    101      -1

Impacted Files	Coverage Δ
packages/checkbox/index.tsx	`89.47% <100%> (+0.14%)`	⬆️
packages/list/ListItem.tsx	`100% <100%> (+2.12%)`	⬆️
packages/list/index.tsx	`92.77% <90.1%> (-0.69%)`	⬇️
packages/layout-grid/Grid.tsx	`91.66% <0%> (ø)`	⬆️
packages/chips/ChipSet.tsx	`98.79% <0%> (ø)`	⬆️
packages/layout-grid/Row.tsx	`80% <0%> (ø)`	⬆️
packages/layout-grid/Cell.tsx	`93.75% <0%> (ø)`	⬆️
packages/drawer/Subtitle.tsx	`66.66% <0%> (ø)`	⬆️
packages/drawer/Title.tsx	`66.66% <0%> (ø)`	⬆️
packages/line-ripple/index.tsx	`98.14% <0%> (ø)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba47022...b2acc81. Read the comment docs.

…nts/material-components-web-react into list/update-prerelease

abhiomkar

LGTM. Please update screenshot test results.

moog16 · 2019-03-19T19:37:39Z

Thanks @abhiomkar - will do!

commit 14b22bc Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <tjy970721@gmail.com> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <ben-mckernan@users.noreply.github.com> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <mattgoo@google.com> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <mattgoo@google.com> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <ecdb.lucas@gmail.com> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <mattgoo@google.com> Date: Fri Mar 15 10:05:03 2019 -0700 fix: classnames@2.2.5 --> classnames@2.2.6 & update imports (#709) commit ae9b421 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716)

* Squashed commit of the following: commit 14b22bc Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <tjy970721@gmail.com> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <ben-mckernan@users.noreply.github.com> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <mattgoo@google.com> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <mattgoo@google.com> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <ecdb.lucas@gmail.com> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <mattgoo@google.com> Date: Fri Mar 15 10:05:03 2019 -0700 fix: classnames@2.2.5 --> classnames@2.2.6 & update imports (#709) commit ae9b421 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716) * feat(text-field): update to v1.1.1 (#812)

Matt Goo added 6 commits March 1, 2019 18:12

WIP: list and checkbox and radio

db48f6c

Merge branch 'rc0.11.0' into list/update-prerelease

fc5e7ff

fix: listitem radio and checkbox

a97a57a

WIP: tests

39cfbd9

WIP: list test

d8710a5

fix: tests

2e77fe0

googlebot added the cla: yes label Mar 13, 2019

Matt Goo added 7 commits March 13, 2019 12:49

Merge branch 'rc0.11.0' into list/update-prerelease

bdb5878

Update tsconfig.json

c424acd

fix: readme and golden

6207c43

Muerge branch 'list/update-prerelease' of github.com:material-compone…

4230bb5

…nts/material-components-web-react into list/update-prerelease

fix: add back props

77c8901

Merge branch 'rc0.11.0' into list/update-prerelease

879f1ad

fix: package-lock

b0264f0

moog16 mentioned this pull request Mar 13, 2019

Use MDC Web Typings #697

Closed

34 tasks

Matt Goo added 2 commits March 14, 2019 12:07

Merge branch 'rc0.11.0' into list/update-prerelease

7cf46f1

fix: update simple dialog

b2acc81

moog16 assigned abhiomkar Mar 14, 2019

moog16 changed the base branch from rc0.11.0 to feat/mdcweb-typescript-update March 18, 2019 23:26

abhiomkar approved these changes Mar 19, 2019

View reviewed changes

Merge branch 'feat/mdcweb-typescript-update' into list/update-prerelease

fd3bcc9

moog16 merged commit a8a1323 into feat/mdcweb-typescript-update Mar 19, 2019

moog16 deleted the list/update-prerelease branch March 19, 2019 21:10

moog16 pushed a commit that referenced this pull request Mar 19, 2019

feat(list): update to MDC Web 1.0.0 (#740)

8166cc8

moog16 pushed a commit that referenced this pull request Mar 19, 2019

feat(list): update to MDC Web 1.0.0 (#740)

e7af289

moog16 pushed a commit that referenced this pull request Mar 20, 2019

feat(list): update to MDC Web 1.0.0 (#740)

2639599

moog16 pushed a commit that referenced this pull request Mar 25, 2019

feat(list): update to MDC Web 1.0.0 (#740)

bc2b36b

gugu pushed a commit to Short-io/material-components-web-react that referenced this pull request Mar 27, 2019

feat(list): update to MDC Web 1.0.0 (material-components#740)

a6c78e6

moog16 pushed a commit that referenced this pull request Apr 30, 2019

feat(list): update to MDC Web 1.0.0 (#740)

4e99b4c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(list): update to MDC Web 1.0.0 #740

feat(list): update to MDC Web 1.0.0 #740

moog16 commented Mar 13, 2019

codecov-io commented Mar 13, 2019 •

edited

Loading

abhiomkar left a comment

moog16 commented Mar 19, 2019

feat(list): update to MDC Web 1.0.0 #740

feat(list): update to MDC Web 1.0.0 #740

Conversation

moog16 commented Mar 13, 2019

codecov-io commented Mar 13, 2019 • edited Loading

Codecov Report

abhiomkar left a comment

Choose a reason for hiding this comment

moog16 commented Mar 19, 2019

codecov-io commented Mar 13, 2019 •

edited

Loading