fix(drawer): add missing foundation import in drawer #821

moog16 · 2019-04-27T16:14:23Z

related #697

codecov-io · 2019-04-27T16:14:28Z

Codecov Report

❗ No coverage uploaded for pull request base (feat/menu-surface/mdcweb-v1@26ca36b). Click here to learn what that means.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##             feat/menu-surface/mdcweb-v1     #821   +/-   ##
==============================================================
  Coverage                               ?   95.14%           
==============================================================
  Files                                  ?       73           
  Lines                                  ?     2924           
  Branches                               ?      449           
==============================================================
  Hits                                   ?     2782           
  Misses                                 ?       46           
  Partials                               ?       96

Impacted Files	Coverage Δ
packages/list/ListItem.tsx	`97.87% <ø> (ø)`
packages/ripple/index.tsx	`89.28% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ca36b...ec88c04. Read the comment docs.

codecov-io · 2019-04-27T16:14:28Z

Codecov Report

❗ No coverage uploaded for pull request base (feat/menu-surface/mdcweb-v1@26ca36b). Click here to learn what that means.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##             feat/menu-surface/mdcweb-v1     #821   +/-   ##
==============================================================
  Coverage                               ?   95.14%           
==============================================================
  Files                                  ?       73           
  Lines                                  ?     2924           
  Branches                               ?      449           
==============================================================
  Hits                                   ?     2782           
  Misses                                 ?       46           
  Partials                               ?       96

Impacted Files	Coverage Δ
packages/list/ListItem.tsx	`97.87% <ø> (ø)`
packages/ripple/index.tsx	`89.28% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ca36b...ec88c04. Read the comment docs.

codecov-io · 2019-04-27T16:14:28Z

Codecov Report

Merging #821 into feat/mdcweb-typescript-update will increase coverage by <.01%.
The diff coverage is 100%.

@@                        Coverage Diff                        @@
##           feat/mdcweb-typescript-update     #821      +/-   ##
=================================================================
+ Coverage                          94.22%   94.22%   +<.01%     
=================================================================
  Files                                 76       76              
  Lines                               3185     3186       +1     
  Branches                             478      478              
=================================================================
+ Hits                                3001     3002       +1     
  Misses                                65       65              
  Partials                             119      119

Impacted Files	Coverage Δ
packages/drawer/index.tsx	`93.91% <100%> (ø)`	⬆️
packages/list/index.tsx	`94.31% <100%> (+0.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6b071...f0a9288. Read the comment docs.

googlebot · 2019-04-27T16:14:33Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-04-27T16:15:06Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-04-27T16:59:03Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

commit 14b22bc Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <tjy970721@gmail.com> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <ben-mckernan@users.noreply.github.com> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <mattgoo@google.com> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <mattgoo@google.com> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <ecdb.lucas@gmail.com> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <mattgoo@google.com> Date: Fri Mar 15 10:05:03 2019 -0700 fix: classnames@2.2.5 --> classnames@2.2.6 & update imports (#709) commit ae9b421 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716)

* Squashed commit of the following: commit 14b22bc Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <tjy970721@gmail.com> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <ben-mckernan@users.noreply.github.com> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <mattgoo@google.com> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <mattgoo@google.com> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <ecdb.lucas@gmail.com> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <mattgoo@google.com> Date: Fri Mar 15 10:05:03 2019 -0700 fix: classnames@2.2.5 --> classnames@2.2.6 & update imports (#709) commit ae9b421 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716) * feat(text-field): update to v1.1.1 (#812)

feat(drawer): missing drawer foundation import

ec88c04

googlebot added the cla: no label Apr 27, 2019

moog16 changed the base branch from feat/menu-surface/mdcweb-v1 to feat/mdcweb-typescript-update April 27, 2019 16:14

moog16 added cla: yes and removed cla: no labels Apr 27, 2019

WIP: add missing adapter

361c09f

fix: remove outlined

f0a9288

williamernest approved these changes Apr 29, 2019

View reviewed changes

moog16 merged commit a6737b5 into feat/mdcweb-typescript-update Apr 29, 2019

moog16 deleted the feat/drawer/v1 branch April 29, 2019 20:11

moog16 pushed a commit that referenced this pull request Apr 30, 2019

fix(drawer): add missing foundation import in drawer (#821)

7adc12a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(drawer): add missing foundation import in drawer #821

fix(drawer): add missing foundation import in drawer #821

moog16 commented Apr 27, 2019

codecov-io commented Apr 27, 2019

codecov-io commented Apr 27, 2019

codecov-io commented Apr 27, 2019 •

edited

Loading

googlebot commented Apr 27, 2019

googlebot commented Apr 27, 2019

googlebot commented Apr 27, 2019

fix(drawer): add missing foundation import in drawer #821

fix(drawer): add missing foundation import in drawer #821

Conversation

moog16 commented Apr 27, 2019

codecov-io commented Apr 27, 2019

Codecov Report

codecov-io commented Apr 27, 2019

Codecov Report

codecov-io commented Apr 27, 2019 • edited Loading

Codecov Report

googlebot commented Apr 27, 2019

googlebot commented Apr 27, 2019

googlebot commented Apr 27, 2019

codecov-io commented Apr 27, 2019 •

edited

Loading