Improve type checks in SitesManager API #22704
Open
+79
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While working on another issue I came across the fact, that the SitesManager API currently does not check the type that is provided when creating or updating a measurable.
This makes it possible to create measurables with an invalid type, or update an existing measurable with one.
This PR therefor introduces a check if the provided type exists.
When updating an existing site, the type will only be checked if it differs from the previous one.
This is done, to ensure that a measurable that already has an invalid type (e.g. due to a removed plugin), is still update-able.
Review