Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plugin is activated for tests #912

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 22, 2024

Description:

This fixture tries to add a measurable of the type mobileapp. The SitesManager API currently does not validate the measurable type provided, but we aim to change this with matomo-org/matomo#22704.

To ensure the tests pass, it's thus required to enable the plugin for it.

Review

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@AltamashShaikh FYI

@snake14 snake14 merged commit 47cad3f into 5.x-dev Oct 22, 2024
5 checks passed
@snake14 snake14 deleted the activatepluginintests branch October 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants