Allow sending no state_events_at_start when user is already part of the current room state (MSC2716)
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the current room state Synapse changes in matrix-org/synapse#11188
MadLittleMods
changed the title
?state_events_at_start when user is already part of the current room state (MSC2716)state_events_at_start when user is already part of the current room state (MSC2716)
MadLittleMods
commented
Oct 26, 2021
4 tasks
MadLittleMods
commented
Oct 29, 2021
| return r.Get("event_id").Str | ||
| }, nil), | ||
| }, | ||
| }) |
There was a problem hiding this comment.
TODO: Once #206 merges, use validateBatchSendRes here ⏩
kegsay
approved these changes
Nov 10, 2021
|
Thanks for the review @kegsay 🐃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sending no
?state_events_at_startwhen user is already part of the current room state (MSC2716).Synapse changes in matrix-org/synapse#11188
Part of MSC2716: matrix-org/matrix-spec-proposals#2716