Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending no state_events_at_start when user is already part of the current room state (MSC2716) #219

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Allow sending no state_events_at_start when user is already part of the current room state (MSC2716) #219

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1c6b74
Allow sending no ?state_events_at_start when user is already part of …
MadLittleMods Oct 26, 2021
400b9e4
Better comment
MadLittleMods Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions tests/msc2716_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,48 @@ func TestImportHistoricalMessages(t *testing.T) {
})
})

t.Run("Should be able to send a batch without any state_events_at_start - user already joined in the current room state", func(t *testing.T) {
t.Parallel()

roomID := as.CreateRoom(t, createPublicRoomOpts)
alice.JoinRoom(t, roomID, nil)

// Create the "live" event we are going to import our historical events next to
eventIDsBefore := createMessagesInRoom(t, alice, roomID, 1)
eventIdBefore := eventIDsBefore[0]
timeAfterEventBefore := time.Now()

// Import a historical event
batchSendRes := batchSendHistoricalMessages(
t,
as,
roomID,
eventIdBefore,
"",
// This is the key thing we're testing,
// no `?state_events_at_start` given
MadLittleMods marked this conversation as resolved.
Show resolved Hide resolved
make([]map[string]interface{}, 0),
createMessageEventsForBatchSendRequest([]string{alice.UserID}, timeAfterEventBefore, 3),
// Status
200,
)
batchSendResBody := client.ParseJSON(t, batchSendRes)
historicalEventIDs := client.GetJSONFieldStringArray(t, batchSendResBody, "event_ids")

messagesRes := alice.MustDoFunc(t, "GET", []string{"_matrix", "client", "r0", "rooms", roomID, "messages"}, client.WithContentType("application/json"), client.WithQueries(url.Values{
"dir": []string{"b"},
"limit": []string{"100"},
}))

must.MatchResponse(t, messagesRes, match.HTTPResponse{
JSON: []match.JSON{
match.JSONCheckOffAllowUnwanted("chunk", makeInterfaceSlice(historicalEventIDs), func(r gjson.Result) interface{} {
return r.Get("event_id").Str
}, nil),
},
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Once #206 merges, use validateBatchSendRes here ⏩

})

t.Run("TODO: Test if historical avatar/display name set back in time are picked up on historical messages", func(t *testing.T) {
t.Skip("Skipping until implemented")
// TODO: Try adding avatar and displayName and see if historical messages get this info
Expand Down