Fix invitations not sending push notifications #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
the
T-Defect
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3207 +/- ##
=======================================
Coverage 66.03% 66.03%
=======================================
Files 507 507
Lines 57107 57126 +19
=======================================
+ Hits 37708 37724 +16
- Misses 15621 15624 +3
Partials 3778 3778
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kegsay
approved these changes
Sep 26, 2023
userapi/consumers/roomserver.go
Outdated
| @@ -448,6 +461,18 @@ func (s *OutputRoomEventConsumer) roomName(ctx context.Context, event *rstypes.H | |||
| } | |||
| } | |||
|
|
|||
| // Special case for invites, as we don't store any "current state" for these events, | |||
| // we need to make sure that, if present, the m.room.name is sent as well. | |||
| if event.Type() == spec.MRoomMember { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests added in matrix-org/sytest#1356 uncovered that we don't consider invitations as events the userapi should handle and thus just don't notify the client about any new invitations received over federation.