-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test that remote invites are correctly pushed #1356
Conversation
I don't understand why there are new failures for Dendrite? |
@@ -630,3 +630,103 @@ sub check_received_push_with_name | |||
); | |||
}); | |||
}; | |||
|
|||
test "Invites over federation are correctly pushed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we making more Sytest tests because there isn't a good way to test push gateway stuff in Complement?
@@ -630,3 +630,103 @@ sub check_received_push_with_name | |||
); | |||
}); | |||
}; | |||
|
|||
test "Invites over federation are correctly pushed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test "Invites over federation are correctly pushed", | |
test "Invites over federation are correctly pushed (without room_name)", |
}; | ||
|
||
|
||
test "Invites over federation are correctly pushed with name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test "Invites over federation are correctly pushed with name", | |
test "Invites over federation are correctly pushed (with room_name)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, not sure I'd pick up on any Perl intricacies/pitfalls if there was any
The tests added in matrix-org/sytest#1356 uncovered that we don't consider invitations as events the userapi should handle and thus just don't notify the client about any new invitations received over federation.
Tests for matrix-org/synapse#15820