Process m.room.encryption events before emitting RoomMember events
#2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to call `onCryptoEvent` earlier in `processSyncResponse`, but we need to have stored the room before doing so. We therefore need to move the call to `storeRoom` earlier. We can actually reduce a bit of duplication by moving the call into `SyncApi.createRoom`. `storeRoom` has relatively few side-effects, so as far as I can tell this should be pretty safe.
richvdh
force-pushed
the
rav/fix_e2e_fail_in_new_room
branch
from
368b30d
to
4ebcb43
Compare
This fixes the problematic race condition.
richvdh
force-pushed
the
rav/fix_e2e_fail_in_new_room
branch
from
4ebcb43
to
6ec8461
Compare
justjanne
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#23819.
Here's what your changelog entry will look like:
🐛 Bug Fixes
m.room.encryptionevents before emittingRoomMemberevents (#2910). Fixes Verification fails to start (intermittently) when there is no existing DM with the target user element-hq/element-web#23819.