Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process m.room.encryption events before emitting RoomMember events #2910

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Process m.room.encryption events before emitting RoomMember events #2910

merged 3 commits into from
Nov 25, 2022

Commits on Nov 25, 2022

  1. Update tests

    @richvdh
    richvdh committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    1f387ba View commit details
    Browse the repository at this point in the history

  2. Call Store.storeRoom earlier 

    We're going to call `onCryptoEvent` earlier in `processSyncResponse`, but we
need to have stored the room before doing so. We therefore need to move the
call to `storeRoom` earlier.

We can actually reduce a bit of duplication by moving the call into
`SyncApi.createRoom`.

`storeRoom` has relatively few side-effects, so as far as I can tell this
should be pretty safe.
    @richvdh
    richvdh committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    9fddae6 View commit details
    Browse the repository at this point in the history

  3. Call onCryptoEvent before processing state events 

    This fixes the problematic race condition.
    @richvdh
    richvdh committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    6ec8461 View commit details
    Browse the repository at this point in the history