This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix --name-width value on _IRCLayout.pcss #10285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Settings.tsx Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
Z-Community-PR
|
Hi @luixxiul thank you for the contribution. Please could we have a screenshot of where this value is used (or actually, not used)? I'm trying to get some context so I can review this. I assume I need to enable IRC mode to see it? |
|
Thanks for the quick review. I'm going to add screenshots soon. |
|
Here is a cropped screenshot of DisambiguatedProfile on IRC layout.
The value of |
|
Thanks for the quick review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
--name-widthon _IRCLayout.pcss.The name width
--name-widthwas set to 70px on this line of #4531, while at the same time the default value was set to 80px on this line of the same PR. The value is still available here.The reason is not clear (it might be related to the profile resizer), but since the latter value has been respected on the UI anyway, I think the former should be able to be changed to 80px.
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
This is a partial retry of #9064, which initially tried to implement a test.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.