IRC ui layout #4531
IRC ui layout #4531
Conversation
|
Still needs some fixes around replies and edits but it's mostly there |
|
This is prettier than I imagined :D |
Begin removing dependence on slider. Move settings to labs. Username disambiguation.
JorikSchellekens
force-pushed
the
joriks/irc-ui
branch
from
8d45203 to
5a0fdb3
Compare
|
Addresses element-hq/element-web#13552 |
|
There's now a way to disambiguate names by hovering over them. |
|
Replies and edits fixed |
|
Looks quite nice, though I'd suggest making the replies less bulky. This is how I addressed that problem in Neo, for example (which seemed to get positive responses from people): |
|
Thanks for looking into this and refactoring the CSS in an area that hasn't received too much love in a while! I am reviewing it now, but doing a quick visual scan between nightly and the adhoc build with IRC layout turned off (both with compact timeline mode on and off) reveals that the layout/spacing has changed a bit, especially in compact mode (if you flip between them in an image viewer it should be apparent). I appreciate it might be hard to keep it exactly the same, but the 2 things I would perhaps consider addressing would be:
The screenshots of what I am seeing: Adhoc build, compact mode
Nightly build, compact mode
Adhoc build, non-compact mode
Nightly build, non-compact mode
|
There was a problem hiding this comment.
Thanks again for looking into this! The resize handle on the sender profile column is really cool!
Some nits and suggestions you could consider (in a follow-up PR would be OK) but code overall looks good!
One thing I would like to see addressed before this is merged (or really short after if we need this today) is the regression of the vertical spacing in the compact mode when irc layout is off as mentioned.
- removed superfluous position and classes - fixed compact view - fixed event list summary avatar and text overlap - fixed a problem where the mention list refuses to load.
|
Ah, the builds are failing because of the dispatcher move. |
|
@JorikSchellekens did you manage to fix the vertical spacing issue mentioned above? |
Perhaps a rebase would help? |
Yup that's fixed |
|
I noticed the notification bar was completely messed up because of the irc layout. Spent most of the morning trying to fix it. It didn't work well so I've just disabled irc for anything which isn't a traditional room. |
Fixes element-hq/element-web#13736 This also fixes an unreported but complained about issue regarding the 'always show timestamps' option not working. Looks like this regressed in #4531 when things got shuffled around.
|
Looks great so far! A simple observation using the nightly: the adjustable width of the nick-column is not persistent between room changes or client restarts. Also this would profit immensely from a monospaced font option. |
This implements a nice irc style ui. Depends on both #4424 and element-hq/element-web#13350
Fixes element-hq/element-web#13552
Requires element-hq/element-web#13350
Live preview: https://riots.im/adhoc/irc-ui-3/