This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix the weird gradient on the spaces bar #12229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds/pop-out-panel # Conflicts: # src/i18n/strings/en_EN.json
Just shows notif & unread counts for main thread if the TAC is enabled.
Hopefully this is a sensible enough way. The panel will stay open of course (ie. if you go to a different room & come back), but that's the nature of the right panel.
Open thread panel when thread clicked in Threads Activity Centre
Make the button 32x32 (and the inner icon 24x24)
Fix narrow hover background on TAC button
Add test for the ThreadsActivityCentre component
Really this mostly just needed a margin above the TAC button (which the Add Space button did) to space it out from the, uh, spaces. Having done that, I got annoyed by the fact that the gradients were percentage-based and so the amount that got faded out depended on how tall your element window was, so most of the changes here are to fix the gradients to be fixed pixel offsets from the top & bottom.
dbkr
added
the
T-Defect
* New gradients with an extra colour stop to bias more of the fade to the extremeties * Fixed issue where the space panel would grow fatter when it was big enough to scroll because we didn't leave space for the scrollbar * Added fixed width for the space panel rather than trying to size it based on contents + padding * Fixed position of the separator line between the user menu and the spacves which should be 12px either side of the separator.
Base automatically changed from
florianduros/threads/pop-out-panel
to
develop
February 7, 2024 14:10
befor the gradient starts. Also put the gradient back to simple two stops.
Smaller 16px gradient and 40px gap between threads icon & bottom space icon
|
Actually the other changes in this were broken so I've split out just the gradient changes to #12262 and will fix the scrollbar separately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really this mostly just needed a margin above the TAC button (which the Add Space button did) to space it out from the, uh, spaces. Having done that, I got annoyed by the fact that the gradients were percentage-based and so the amount that got faded out depended on how tall your element window was, so most of the changes here are to fix the gradients to be fixed pixel offsets from the top & bottom.
Fixes https://github.com/element-hq/wat-internal/issues/148
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes