Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Get rid of dependence on usercontent.riot.im #4046

Merged
merged 6 commits into from
Feb 19, 2020
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 7, 2020

…ix-org/matrix-react-sdk into t3chguy/usercontent
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review February 13, 2020 16:55
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, hurrah for finally fixing this :)

I assume making an object URL inside the sandboxed iframe, then passing it back to the main frame and using it as the src doesn't work?

Also looks like this still requires the two clicks for decrypt/download? This is another thing that would be good to fix somehow.

src/usercontent/index.js Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member Author

t3chguy commented Feb 17, 2020

I assume making an object URL inside the sandboxed iframe, then passing it back to the main frame and using it as the src doesn't work?

browser doesn't let user click on it

Also looks like this still requires the two clicks for decrypt/download? This is another thing that would be good to fix somehow.

indeed, will spin up an issue for this

@dbkr
Copy link
Member

dbkr commented Feb 18, 2020

ok - fair enough, re-lgtm

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Member Author

t3chguy commented Feb 19, 2020

element-hq/element-web#9035 tracks having to click twice

@t3chguy t3chguy merged commit b1b17a3 into develop Feb 19, 2020
@t3chguy t3chguy deleted the t3chguy/usercontent branch May 25, 2020 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants